Skip to content

mMainComponentName Keep in line with above in ReactActivityDelegate#32685

Closed
zhpd wants to merge 1 commit into
facebook:mainfrom
zhpd:main
Closed

mMainComponentName Keep in line with above in ReactActivityDelegate#32685
zhpd wants to merge 1 commit into
facebook:mainfrom
zhpd:main

Conversation

@zhpd
Copy link
Copy Markdown
Contributor

@zhpd zhpd commented Dec 1, 2021

Summary

public String getMainComponentName() {
    return mMainComponentName;
}

protected void onCreate(Bundle savedInstanceState) {
    String mainComponentName = getMainComponentName();
    mReactDelegate =
        new ReactDelegate(
            getPlainActivity(), getReactNativeHost(), mainComponentName, getLaunchOptions()) {
          @Override
          protected ReactRootView createRootView() {
            return ReactActivityDelegate.this.createRootView();
          }
        };
    // mMainComponentName rename is mainComponentName 
    if (mainComponentName != null) {
      loadApp(mainComponentName);
    }
  }

Changelog

[CATEGORY] [TYPE] - Message

Test Plan

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Dec 1, 2021
@pull-bot
Copy link
Copy Markdown

pull-bot commented Dec 1, 2021

Messages
📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 10ed6cc

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: f3bf2e4
Branch: main

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,364,719 +9
android hermes armeabi-v7a 7,690,918 +13
android hermes x86 8,840,503 +11
android hermes x86_64 8,780,754 +15
android jsc arm64-v8a 9,679,646 +4
android jsc armeabi-v7a 8,667,346 +7
android jsc x86 9,635,744 +5
android jsc x86_64 10,232,784 +11

Base commit: f3bf2e4
Branch: main

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cortinico has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @zpd106 in 0aee733.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants